[U-Boot] [PATCH 1/2] kirkwood: implement kw_sdram_bs_set()

Marek Vasut marex at denx.de
Thu Jul 5 17:51:52 CEST 2012


Dear Gerlando Falauto,

> On 07/05/2012 05:38 PM, Marek Vasut wrote:
> > Dear Gerlando Falauto,
> > 
> >> Some boards might be equipped with different SDRAM configurations.
> >> When that is the case, CPU CS Window Size Register (CS[0]n Size) should
> >> be set to the biggest value through board.cfg file; then its value
> >> can be fixed at runtime according to the detected SDRAM size.
> >> 
> >> Therefore, implement kw_sdram_bs_set(), to be called for instance within
> >> board_early_init_f().
> > 
> > [..]
> > 
> >> +/*
> >> + * kw_sdram_bs_set - writes SDRAM Bank size
> >> + */
> >> +void kw_sdram_bs_set(enum memory_bank bank, u32 size)
> > 
> > The enum is declared somewhere, right ?
> 
> Yes, in arch/arm/include/asm/arch-kirkwood/cpu.h.
> 
> It's the same enum also used by other functions {declared, defined}
> within the same {header, source} file, like:
> 
> u32 kw_sdram_bs(enum memory_bank bank)

Good, add my

Reviewed-by: Marek Vasut <marex at denx.de>

> 
> Best regards,
> Gerlando

Best regards,
Marek Vasut


More information about the U-Boot mailing list