[U-Boot] [PATCH v2 5/5] arm: rmobile: Add supoprt for KMC KZM-A9-GT board

Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj at renesas.com
Thu Jul 5 23:58:01 CEST 2012


Hi,

Thank you for your review.

2012/7/5 Tetsuyuki Kobayashi <koba at kmckk.co.jp>:
> Hello, Iwamatsu-san
>
>
> (2012/07/05 16:01), Nobuhiro Iwamatsu wrote:
>
>> diff --git a/board/kmc/kzm9g/kzm9g.c b/board/kmc/kzm9g/kzm9g.c
>> new file mode 100644
>> index 0000000..3f38f69
>> --- /dev/null
>> +++ b/board/kmc/kzm9g/kzm9g.c
>
> [...]
>>
>> +void s_init(void)
>> +{
>
> [...]
>
>> +       /* Secure control register Init */
>> +       #define LIFEC_SEC_SRC_BIT       (1 < 15)
>> +       writel(readl(LIFEC_SEC_SRC) & ~LIFEC_SEC_SRC_BIT, LIFEC_SEC_SRC);
>
>
> (1 < 15) ?
> It seems strange. typo of (1 << 15) ?
>
>
>             -           actux1:FLASH1X8
>>
>> diff --git a/include/configs/kzm9g.h b/include/configs/kzm9g.h
>> new file mode 100644
>> index 0000000..62ecadc
>> --- /dev/null
>> +++ b/include/configs/kzm9g.h
>
> [...]
>
>> +
>> +#ifndef __KZM_A9_GT_H
>> +#define __KZM_A9_GT_H
>
>
> Trivial.
> __KZM9G_H
>
>> +#endif /* __KZM_A9_GT_H */
>>
> __KZM9G_H
>
>

Thanks, I will fix these.

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu


More information about the U-Boot mailing list