[U-Boot] [PATCH 2/2] [v2] net: abort network initialization if the PHY driver fails
Wolfgang Denk
wd at denx.de
Fri Jul 6 21:04:49 CEST 2012
Dear Timur Tabi,
In message <1341599739-17812-1-git-send-email-timur at freescale.com> you wrote:
> Now that phy_startup() can return an actual error code, check for that error
> code and abort network initialization if the PHY fails.
...
> if (fec->phydev) {
> /* Start up the PHY */
> - phy_startup(fec->phydev);
> + int ret = phy_startup(fec->phydev);
> + if (ret) {
Blank line after variable declarations, please.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Software suppliers are trying to make their software packages more
``user-friendly''. . . . Their best approach, so far, has been to
take all the old brochures, and stamp the words, ``user-friendly'' on
the cover. - Bill Gates
More information about the U-Boot
mailing list