[U-Boot] [PATCH] armv7: Fix to mistake clean the memory space

Andreas Bießmann andreas.devel at googlemail.com
Sat Jul 7 09:29:10 CEST 2012


Dear Zhong Hongbo,

Am Freitag, 6. Juli 2012 schrieb Zhong Hongbo :

    On 07/06/2012 09:57 PM, Andreas Bießmann wrote:
    > Dear Zhong Hongbo,
    >
    > On 06.07.2012 15:50, Zhong Hongbo wrote:
    >> On 07/06/2012 09:23 PM, Andreas Bießmann wrote:
    >>> On 06.07.2012 14:20, Zhong Hongbo wrote:
    >>>> From: Zhong Hongbo <bocui107 at gmail.com <javascript:;>>
    >>>>
    >>>> In currently, when __bss_start is equal to __bss_end__,
    >>>> The bss loop will clear all the things in memory space.
    >>>>
    >>>> But just only when __bss_end__ greater than __bss_start__,
    >>>> we do the clear bss section operation.
    >>>>
    >>>> Signed-off-by: Hongbo Zhong <bocui107 at gmail.com <javascript:;>>
    >>>> Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com
    <javascript:;>>
    >>>
    >>> well this is wrong, I would maybe ack it
    Hi Andreas,

    How I do it? Signed-off-by or Reviewed-by?


you do not need to put these lines in at all, the reviewer will reply
your mail with the correct line (Acked-by, Reviewed-by, Tested-by) in
it. A tool called patchwork will then provide some convenience for the
custodians. He just pulls the mbox file from patchwork which has all the
collected lines in it. The resulting commit in the custodian repository
will contain all these linesgathered while in review process.
You ought to put some other people on cc so they can review the patch.
This can easily achieved by putting a 'cc: <some email>' into the patch.
Git will then put these addresses on cc automagicly.

Best regards

Andreas Bießmann


More information about the U-Boot mailing list