[U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000

Tetsuyuki Kobayashi koba at kmckk.co.jp
Mon Jul 9 04:42:15 CEST 2012


Dear Wolfgang Denk,

(07/09/2012 04:58 AM), Wolfgang Denk wrote:
> Dear Tetsuyuki Kobayashi,
> 
> In message <4FE85B87.6090302 at kmckk.co.jp> you wrote:
>> NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000.
> 
> Your patch is OK per se, but please note that it is a mandatory
> requirement that CONFIG_SYS_HZ == 1000.  So if you have any board
> where this is not the case, this board needs to be fixed, too.

Thank you for reviewing my patch.

I didn't know that it is a mandatory requirement that CONFIG_SYS_HZ == 1000.
I grep'ed for CONFIG_SYS_HZ in README and under doc/, but I could not find any description about it.

  $ grep -r CONFIG_SYS_HZ README doc/*
  doc/README.LED:(CONFIG_SYS_HZ / <N>) where <N> is the frequency of the blink. Typical values

And I couldn't find that what value should be return in ulong get_timer(ulong base);
I hope "how to implement system timer" documented.

Best regards,

Tetsuyuki Kobayashi





More information about the U-Boot mailing list