[U-Boot] [PATCH] fdt: send all dtc output to stderr

Wolfgang Denk wd at denx.de
Mon Jul 9 09:08:19 CEST 2012


Dear Stephen Warren,

In message <1339194497-24208-1-git-send-email-swarren at wwwdotorg.org> you wrote:
> From: Stephen Warren <swarren at nvidia.com>
> 
> Commit 896bbb5 "fdt: avoid bad MAKEALL status" added logic to capture
> the result code from dtc by echoing $? to stdout and capturing it using
> $(). However, dtc emits some diagnostics to stderr and some to stdout.
> The diagnostics send to stdout ended up getting captured via $() rather
> than being echo'd to the user. This caused those diagnostics to be passed
> to the exit command, which would then fail with the following cryptic
> error message:
> 
>     /bin/sh: line 1: exit: too many arguments
> 
> Solve this by redirecting all dtc output to stderr so that $() does not
> capture it. This allows the user to see the actual error message from dtc.
> 
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: albert.u.boot at aribaud.net
> Cc: Tom Warren <twarren at nvidia.com>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>  dts/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be wiser than other people if you can, but do not tell them so.
                                       -- Philip Earl of Chesterfield


More information about the U-Boot mailing list