[U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

[Wolfgang Denk]

Dear Holger,

In message <4FFAC8C9.1020603 at keymile.com> you wrote:
> 
> > Anyways peripheral driver should go in drivers/
> 
> yes there are maybe drivers which proof your concept, but there are many others
> in the board related code which do the opposite.

Yes, but bad examples are not a good reason to repeat mistakes either.

> But I think this topic should be discussed not in the context of this patch.
> It's a general question. I 100% agree with Detlev's explanation. If a new very
> limited HW driver is added to the repo I see good reasons to keep it in the
> folder for the board. If a second user comes up and wants to enhance the driver
> for his needs he can still move driver then. But if no other user for this
> driver is there and maybe in the future the board needs to be removed because
> it's broken it's much easier to remove _all_ related code when it's located in
> one directory. If the code is spread over several directories it's much harder
> to track.

Sorry, but I disagree.  How many board directories are there in
U-Boot?  Several hundreds...  How many board directories did you check
to make sure none of them contains any driver that is similar to what
you implement here?

If we place the driver in your board diretory, the chances are huge it
will simply sit there and rot, and the next one who needs something
similar will reinvent the wheel because he did not find your copy.

I agree that even very simple and uncomplete implementations can co in
if the fulfil some purpose, and can form a basis for future
extensions. 

To make sure everybody sees such code, we should really add it to the
standard locations.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The best things in life are for a fee.