[U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

Holger Brunck holger.brunck at keymile.com
Mon Jul 9 16:44:31 CEST 2012


Hi Detlev,

On 07/09/2012 03:06 PM, Detlev Zundel wrote:
>> If we place the driver in your board diretory, the chances are huge it
>> will simply sit there and rot, and the next one who needs something
>> similar will reinvent the wheel because he did not find your copy.
>>
>> I agree that even very simple and uncomplete implementations can co in
>> if the fulfil some purpose, and can form a basis for future
>> extensions. 
> 
> I just read through our documentation on the Wiki and found nothing
> relavant to such a topic.  If we make this a requirement, we should add
> it so people know about it beforehand.
> 
> How about amending the U-Boot design principles with 
> 
> 11. Keep It Generic
> 
> - Generic code shall be added as high as possible to the U-Boot
>   abstraction hierarchy and only as a last resort into board
>   directories.  This entails that peripheral drivers should be put below
>   "drivers" even if they start out supporting only one specific
>   configuration.  Note that it is not a requirement for such a first
>   instance to be generic as genericity generally cannot be extrapolated
>   from a single data point.
> 
> How does that sound?
> 

shouldn't be there an exception for strictly board specific peripheral drivers
like an custom-made FPGA?

Regards
Holger



More information about the U-Boot mailing list