[U-Boot] [PATCH 02/13] S3C64XX: Switch to use readl/writel to operate nand flash

[Scott Wood]

On 07/07/2012 04:57 AM, Zhong Hongbo wrote:
> +static inline unsigned int s3c64xx_get_base_nand(void)
> +{
> +	return ELFIN_NAND_BASE;
> +}

unsigned long or uintptr_t would be more appropriate, even if U-Boot is
unlikely to be 64-bit any time soon.

Or better, "struct s3c64xx_nand *".

> @@ -89,15 +96,16 @@ static void s3c_nand_select_chip(struct mtd_info *mtd, int chip)
>   */
>  static void s3c_nand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl)
>  {
> +	struct s3c64xx_nand *const nand = s3c_get_base_nand();

Is there any benefit to declaring local variables const like this?  Why
this one and not all the others that never get altered?

-Scott