[U-Boot] [PATCH V3 2/3] arm/davinci: spl - boot device selection

[Tom Rini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/11/2012 05:08 AM, Sughosh Ganu wrote:
> On Wed Jul 11, 2012 at 04:43:19AM -0700, Tom Rini wrote:
>> On 07/11/2012 04:05 AM, Sughosh Ganu wrote:
> 
> <snip>
> 
>>>> I'm fine saying that we should wrap the call around an #if,
>>>> but I would expect it to be set in the common case and only
>>>> not set in custom production boards.
>>> 
>>> Correct, so all that is needed for SD/MMC loading can still be
>>> kept separate from, say nand load in the spl.c file, isn't it.
>>> So if sd/mmc spl load needs heap to be set up, can't it be done
>>> only for that case.
>> 
>> Yes, but we don't want to have N locations that set up the heap.
>> We want one location that will, if the board has defined a heap
>> area, we set it up.  Or to put it another way, calling
>> mem_malloc_init isn't part of the mmc boot-flow, it's part of the
>> general boot flow.
> 
> Fair enough. My only concern was just that if some feature is not 
> needed for a board, it should be possible to exclude it out.

To be clear, absolutely agreed.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJP/W50AAoJENk4IS6UOR1W6VEQAJ2C+IlU/irdxIBQJkWKdGoe
Rwr1bdQpnUIA4ILEBuD7jwiDj/Q6znfzUQf0XXZuRg+ShYu10y/2HBazn/alfrMj
FyLqm7YnjxDoWpfbSzR5EajdUOD7UgdDbZURwyte/NQos2WeS89IZTrlIT5sxfYV
L7DT0fDdK4pfh7+gArr99Ge/eE3ddm9kVdoxFbvYsr0BQs8xLnjh7t1DZ2rk0P7Y
AabwKIiM1o7xNn5GPIb7lraO4A1/m7U1/if2ad+I/qtEsAnsTC+Ds7VPvnxSdK/w
ga/r/OcYzpQLHna0dBQ4qXqnl5hKDARw3ZX2EYiqxRECRDLMDo2OWJio2F7yEqID
nYhhVKFNcSIC6mcIz1DyPGd/q3QFziCRFfFq0xrfF6K2rNByfXK4xHdld33EFvM1
V7Kfu8XSXeswGU41T+I6hHZyaCFWeNzDBTF/JtfXoZ0IoGgb045JLc6i14KAmwpO
AVCLhQy64h4O7BfvrzYK5u93RmI0PtjdXwkrBMpqAcICwsiPJ0mAU2azYQNbhYVk
NJM5xecgobni0HQek1f/UgzwllwDusjrjo5Hv+Di/D5wYBYTOWxPKZGEHOWfcuf6
O/io1QVQc3FMdrU3cCf5kB/tDAXDOpENhStCkkCgbFVf6u2hVz4vdSxV7oZ5Gmkp
bpFoazwtHzXpzE5B6eIe
=kJeB
-----END PGP SIGNATURE-----