[U-Boot] [PATCH V2 1/1] net: phy: micrel: make ksz9021 phy accessible

[Joe Hershberger]

Hi Troy,

On Wed, Jul 11, 2012 at 1:54 PM, Troy Kisky
<troy.kisky at boundarydevices.com> wrote:
> On 7/11/2012 1:28 AM, Prafulla Wadaskar wrote:
>>
>>
>>> -----Original Message-----
>>> From: u-boot-bounces at lists.denx.de [mailto:u-boot-
>>> bounces at lists.denx.de] On Behalf Of Dirk Behme
>>> Sent: 11 July 2012 12:23
>>> To: u-boot at lists.denx.de; Joe Hershberger
>>> Subject: Re: [U-Boot] [PATCH V2 1/1] net: phy: micrel: make ksz9021
>>> phy accessible
>>>
>>> On 11.07.2012 02:53, Troy Kisky wrote:
>>>>
>>>> On 6/28/2012 11:00 AM, Troy Kisky wrote:
>>>>>
>>>>> Micrel accidentally used the same part number
>>>>> for the KS8721 and KSZ9021. So, both cannot be
>>>>> in the same build of u-boot. Add a config option
>>>>> to handle this.
>>>>>
>>>>> Signed-off-by: Troy Kisky <troy.kisky at boundarydevices.com>
>>>>> Acked-by: Vladimir Zapolskiy <vz at mleia.com>
>>>>>
>>>>> ---
>>>>> v2: add ack
>>>>> ---
>>>>>    drivers/net/phy/micrel.c        |   15 +++++++++++++--
>>>>>    include/configs/mx6qsabrelite.h |    1 +
>>>>>    2 files changed, 14 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
>>>>> index e3043df..30f3264 100644
>>>>> --- a/drivers/net/phy/micrel.c
>>>>> +++ b/drivers/net/phy/micrel.c
>>>>> @@ -35,6 +35,12 @@ static struct phy_driver KSZ804_driver = {
>>>>>         .shutdown = &genphy_shutdown,
>>>>>    };
>>>>>
>>>>> +#ifndef CONFIG_PHY_MICREL_KSZ9021
>>>>> +/*
>>>>> + * I can't believe Micrel used the exact same part number
>>>>> + * for the KSZ9021
>>>>> + * Shame Micrel, Shame!!!!!
>>
>> These comments attracted my attention. I doubt these are valid comments
>> that should get mainlined???
>>
>> Regards...
>> Prafulla . . .
>>
> Yeah, I was a little pissed when I found this problem. Joe, do you want me
> to tone down the language?
> I still think Micrel should be very embarrassed to have done such a thing.

I don't care either way.  I already applied it, so if you or others
care to change it, submit it as a patch on top.

Thanks,
-Joe