[U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location

[sun york-R58495]

On Jul 12, 2012, at 9:30 PM, Wolfgang Denk wrote:

> Dear York,
> 
> In message <9F5356FB-8CA2-44DE-9089-64ABD82CA733 at freescale.com> you wrote:
>> 
>> That patch itself is OK. But the comment is incorrect. We keep
>> adding more mac addresses to this data structure. The CRC was at the
>> end. The offset 0xCC was correct.
> 
> This is a totally broken design then, when you have a growing data
> structure where vital information fields get shifted.  In such case,
> the CRC should have been at the beginning, so it never changes
> location. Or even better, you should not have used a binary data
> structure at all (guess why the environment in U-Boot has been
> implemented the way it is).

I agree it was a broken design. Now we are using all available space and put CRC to the very end. It is not perfect but should work.

York