[U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location

Timur Tabi b04825 at freescale.com
Fri Jul 13 23:39:25 CEST 2012


Wolfgang Denk wrote:
> Well, if it's really so unimportant and used in only a small number
> of boards, then just omit this broken code that provokes the
> undefined behaviour.

As I said before, we need to support situations where people upgrade their
U-Boot.  When the EEPROM is read, the CRC is checked in both locations.
If it's valid in either, then we assume the data is valid and continue.

When the user wants to write back the EEPROM (via the "mac save" command),
the CRC is written only at the proper location (0xFC).  This "fixes" the
EEPROM, and the code will never read the CRC from the wrong location (0xCC).

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the U-Boot mailing list