[U-Boot] [PATCH 2/2] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment

Ilya Yanok ilya.yanok at cogentembedded.com
Sun Jul 15 00:11:07 CEST 2012


Dear Marek,

On Tue, Jul 10, 2012 at 5:55 AM, Marek Vasut <marex at denx.de> wrote:

>
> > > +       invalidate_dcache_range((uint32_t)buffer,
> > > +               ALIGN_END_ADDR(u8, buffer, length));
> >
> > We shouldn't use ALIGN_END_ADDR here. This can lead to strange results on
> > systems with ARCH_DMA_MINALIGN < 32.
>
>
> Good point, ALIGN_END_ADDR should align it to max(32, length) ?
>
> Hm.. no, actually we should align buffer length to ARCH_DMA_MINALIGN.

Regards, Ilya.


More information about the U-Boot mailing list