[U-Boot] [RFC PATCH 2/2] i.MX28: use a clear name for DDR2 initialization

[Stefano Babic]

On 16/07/2012 22:39, Otavio Salvador wrote:
> The mx28 prefix has been added to the initialization data and function
> so it is clear by which SoC it is used as i.MX233 will have a specific
> one.
> 
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---

Hi Otavio,

>  arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c b/arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c
> index e17a4d7..7317a97 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c
> @@ -31,7 +31,7 @@
>  
>  #include "mx28_init.h"
>  
> -uint32_t dram_vals[] = {
> +uint32_t mx28_dram_vals[] = {
>  	0x00000000, 0x00000000, 0x00000000, 0x00000000,
>  	0x00000000, 0x00000000, 0x00000000, 0x00000000,
>  	0x00000000, 0x00000000, 0x00000000, 0x00000000,
> @@ -88,14 +88,14 @@ void __mx28_adjust_memory_params(uint32_t *dram_vals)
>  void mx28_adjust_memory_params(uint32_t *dram_vals)
>  	__attribute__((weak, alias("__mx28_adjust_memory_params")));


Simply a general remark - I think we can discuss further when first
patches forMX23 will be submitted. However, I think is a bad idea to
specialize functions to a specific SOC. If a driver needs such as
function, we will introduce some nasty #ifdef in driver code only to
select which function must be called. And we duplicate this problem in
all drivers.

Instead of that, we could use the same general name. Where do we put
mx23 code ? If we put it together with mx28 code (I mean in the same
directory) we could extract specific SOC function from general files and
use the mechanism provided by Makefile to compile the right one, for
example:

COBJS-$(CONFIG_MX28)	+= spl_mem_mx28.o
COBJS-$(CONFIG_MX23)	+= spl_mem_mx23.o

and spl_mem_init.c contains general code. Drivers call always the same
function. Of course, this is only an example. At the moment, most mx28
function have the mx28_ prefix, but this is acceptable because up now
the mx28 is the only one in this architecture.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================