[U-Boot] [PATCH] tools: Fix mingw tools build

[Mike Frysinger]

On Saturday 07 July 2012 16:05:06 Vladimir Yakovlev wrote:
> --- a/tools/mkenvimage.c
> +++ b/tools/mkenvimage.c
> @@ -45,6 +45,13 @@
> 
>  #define CRC_SIZE sizeof(uint32_t)
> 
> +#ifdef __MINGW32__
> +#define FILE_PERM		(S_IRUSR | S_IWUSR)
> +#else
> +#define FILE_PERM		(S_IRUSR | S_IWUSR | S_IRGRP |\
> +					     S_IWGRP)
> +#endif

err, i'd rather you didn't do this.  we've tried very hard to avoid sprinkling 
arch-specific crap (like __MINGW32__) in random files. instead, i'd like to see 
in (either in os_support.h or mingw_support.h):
#ifndef S_IRGRP
# define S_IRGRP 0
#endif
#indef S_IWGRP
# define S_IWGRP 0
#endif

then no one has to care about mingw, and we don't have to add complicated 
defines that disconnect the locations of the code (the define and the open()).
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120718/b6817417/attachment.pgp>