[U-Boot] [PATCH 7/7] FAT: Make it possible to read from any file position

Mike Frysinger vapier at gentoo.org
Fri Jul 20 05:02:35 CEST 2012


On Thursday 19 July 2012 19:17:31 Benoît Thébaudeau wrote:
> On Friday 20 July 2012 00:44:52 Mike Frysinger wrote:
> > On Thursday 19 July 2012 18:03:06 Benoît Thébaudeau wrote:
> > > --- u-boot-66714b1.orig/fs/fat/fat.c
> > > +++ u-boot-66714b1/fs/fat/fat.c
> > > 
> > > +__u8 get_contents_vfatname_block[MAX_CLUSTSIZE]
> > > +	__aligned(ARCH_DMA_MINALIGN);
> > 
> > is there any reason for this to be exported ?  could you mark it
> > static ?
> 
> I'll do that. There are probably other variables in fat.c missing static,
> so I'll do a dedicated patch before this series. That will shift the patch
> numbers. How should I repost the new version of the series? Should I keep
> the message ID of each patch even if the numbering changes, or should I
> post a v2 completely separately from v1?

it's easier on everyone to do this.  you might want to look at tools/patman/ 
as a way for managing the review process.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120719/d0029746/attachment.pgp>


More information about the U-Boot mailing list