[U-Boot] [PATCH v2] kirkwood: add support for Iomega iConnect board

[Luka Perkov]

Hi Prafulla,

On Thu, Jul 19, 2012 at 11:02:58PM -0700, Prafulla Wadaskar wrote:
> >  board/iomega/iconnect/kwbimage.cfg |  165
> > ++++++++++++++++++++++++++++++++++++
> 
> Is this file (kwbimage.cfg) 100% clone from any existing file already mainlined?

No, but I did not check with all .cfg files. Should I?

> > +	/* Multi-Purpose Pins Functionality configuration */
> > +	u32 kwmpp_config[] = {
> > +		MPP0_NF_IO2,
> > +		MPP1_NF_IO3,
> > +		MPP2_NF_IO4,
> > +		MPP3_NF_IO5,
> > +		MPP4_NF_IO6,
> > +		MPP5_NF_IO7,
> > +		MPP6_SYSRST_OUTn,
> > +		MPP7_GPO,
> > +		MPP8_TW_SDA,
> > +		MPP9_TW_SCK,
> > +		MPP10_UART0_TXD,
> > +		MPP11_UART0_RXD,
> > +		MPP12_GPO,
> > +		MPP13_SD_CMD,
> > +		MPP14_SD_D0,
> > +		MPP15_SD_D1,
> > +		MPP16_SD_D2,
> > +		MPP17_SD_D3,
> > +		MPP18_NF_IO0,
> > +		MPP19_NF_IO1,
> > +		MPP20_GE1_0,
> > +		MPP21_GE1_1,
> > +		MPP22_GE1_2,
> > +		MPP23_GE1_3,
> > +		MPP24_GE1_4,
> > +		MPP25_GE1_5,
> > +		MPP26_GE1_6,
> > +		MPP27_GE1_7,
> > +		MPP28_GPIO,
> > +		MPP29_GPIO,
> > +		MPP30_GE1_10,
> > +		MPP31_GE1_11,
> > +		MPP32_GE1_12,
> > +		MPP33_GE1_13,
> > +		MPP34_GE1_14,
> > +		MPP35_GPIO,
> > +		MPP36_AUDIO_SPDIFI,
> > +		MPP37_AUDIO_SPDIFO,
> > +		MPP38_GPIO,
> > +		MPP39_TDM_SPI_CS0,
> > +		MPP40_TDM_SPI_SCK,
> > +		MPP41_GPIO,
> > +		MPP42_GPIO,
> > +		MPP43_GPIO,
> > +		MPP44_GPIO,
> > +		MPP45_GPIO,
> > +		MPP46_GPIO,
> > +		MPP47_GPIO,
> > +		MPP48_GPIO,
> > +		MPP49_GPIO,
> > +		0
> > +	};
> 
> As per your schematics, please document possible MPPs being used for what purpose.

I dont have schematics, but this values are proven to work. This patch
has been in OpenWrt for quite some time, this is updated and cleaner
version...

> > +#define CONFIG_IDENT_STRING	" Iomega iConnect Wireless"
> 
> The strings looks to be too long, is it possible to shorten it?

Would this be ok:

#define CONFIG_IDENT_STRING	" Iomega iConnect"

> Reset other thinks looks okay to me.

Great.

Regards,
Luka