[U-Boot] [PATCH v2] kirkwood: add support for Iomega iConnect board

[Prafulla Wadaskar]

> -----Original Message-----
> From: Wojciech Dubowik [mailto:Wojciech.Dubowik at neratec.com]
> Sent: 20 July 2012 15:39
> To: Luka Perkov
> Cc: Prafulla Wadaskar; u-boot at lists.denx.de; tim at night-shade.org.uk
> Subject: Re: [PATCH v2] kirkwood: add support for Iomega iConnect
> board
> 
> I have looked at original linux source from Mapower and added
> some description.
> 
> I also don't have schematics...
> 
> Br,
> Wojtek
> 
> On 07/20/2012 10:53 AM, Luka Perkov wrote:
> > Hi Prafulla,
> >
> > On Thu, Jul 19, 2012 at 11:02:58PM -0700, Prafulla Wadaskar wrote:
> >>>   board/iomega/iconnect/kwbimage.cfg |  165
> >>> ++++++++++++++++++++++++++++++++++++
> >> Is this file (kwbimage.cfg) 100% clone from any existing file
> already mainlined?
> > No, but I did not check with all .cfg files. Should I?

Yes, if you can, it would be good since we can avoid one complete file in this patch.

> >
> >>> +	/* Multi-Purpose Pins Functionality configuration */
> >>> +	u32 kwmpp_config[] = {
> >>> +		MPP0_NF_IO2,
> >>> +		MPP1_NF_IO3,
> >>> +		MPP2_NF_IO4,
> >>> +		MPP3_NF_IO5,
> >>> +		MPP4_NF_IO6,
> >>> +		MPP5_NF_IO7,
> I think these are used for NAND
> >>> +		MPP6_SYSRST_OUTn,
> Reset signal
> >> +		MPP7_GPO,
> >> +		MPP8_TW_SDA,
> >> +		MPP9_TW_SCK,
> MPP8-9 I2C
> >>> +		MPP10_UART0_TXD,
> >>> +		MPP11_UART0_RXD,
> Serial
> >>> +		MPP12_GPO,
> This should be MPP12_GPIO as it's a reset button
> >>> +		MPP13_SD_CMD,
> >>> +		MPP14_SD_D0,
> >>> +		MPP15_SD_D1,
> >>> +		MPP16_SD_D2,
> >>> +		MPP17_SD_D3,
> >>> +		MPP18_NF_IO0,
> >>> +		MPP19_NF_IO1,
> >>> +		MPP20_GE1_0,
> >>> +		MPP21_GE1_1,
> >>> +		MPP22_GE1_2,
> >>> +		MPP23_GE1_3,
> >>> +		MPP24_GE1_4,
> >>> +		MPP25_GE1_5,
> >>> +		MPP26_GE1_6,
> >>> +		MPP27_GE1_7,
> >>> +		MPP28_GPIO,
> >>> +		MPP29_GPIO,
> >>> +		MPP30_GE1_10,
> >>> +		MPP31_GE1_11,
> >>> +		MPP32_GE1_12,
> >>> +		MPP33_GE1_13,
> >>> +		MPP34_GE1_14,
> >>> +		MPP35_GPIO,
> This is OTB button
> >>> +		MPP36_AUDIO_SPDIFI,
> >>> +		MPP37_AUDIO_SPDIFO,
> >>> +		MPP38_GPIO,
> >>> +		MPP39_TDM_SPI_CS0,
> >>> +		MPP40_TDM_SPI_SCK,
> >>> +		MPP41_GPIO,
> >>> +		MPP42_GPIO,
> >>> +		MPP43_GPIO,
> >>> +		MPP44_GPIO,
> >>> +		MPP45_GPIO,
> >>> +		MPP46_GPIO,
> >>> +		MPP47_GPIO,
> >>> +		MPP48_GPIO,
> >>> +		MPP49_GPIO,
> MPP41 => led brightness (default on)
> MPP42 => Blue power led
> MPP43 => Red power led
> MPP44-47 => USB Leds 1-4
> MPP48 => OTB Led
> MPP49 not used

Please leave those GPIO usage as comments for respective line
Leave the MPPs for standard peripheral.
 
> >>> +		0
> >>> +	};
> >> As per your schematics, please document possible MPPs being used
> for what purpose.
> > I dont have schematics, but this values are proven to work. This
> patch
> > has been in OpenWrt for quite some time, this is updated and cleaner
> > version...
> >
> >>> +#define CONFIG_IDENT_STRING	" Iomega iConnect Wireless"
> >> The strings looks to be too long, is it possible to shorten it?
> > Would this be ok:
> >
> > #define CONFIG_IDENT_STRING	" Iomega iConnect"

That looks better (shorter) :-)

Regards...
Prafulla . . .