[U-Boot] [PATCH v2] video: support exynos fimd driver for various exynos series

[Minkyu Kang]

On 20 July 2012 17:28, Anatolij Gustschin <agust at denx.de> wrote:
> Hi,
>
> On Thu, 19 Jul 2012 10:30:44 +0900
> Donghwa Lee <dh09.lee at samsung.com> wrote:
>
>> This patch support exynos fimd driver for various exynos series different from
>> existing it supports only exynos4 chip.
>>
>> Signed-off-by: Donghwa Lee <dh09.lee at samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
>> ---
>> Changes for v1:
>>       - moves exynos_fimd_get_base_offset() to exynos_fb.h
>
> Why? This function is used in exynos_fimd.c file only.  Moving it
> to the header file will result in a warning when compiling files
> including exynos_fb.h. This function should be in exynos_fimd.c.
>

Good point : )
Donghwa misunderstood my opinion, maybe.
I want to move this function to arch/arm/include/asm/arch-exynos/fb.h.
not drivers/video/exynos_fb.h.
Because define values and accessor function should be in same header file.

Thanks.
Minkyu Kang.
-- 
from. prom.
www.promsoft.net