[U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command
Marek Vasut
marex at denx.de
Fri Jul 20 23:11:33 CEST 2012
Dear Mike Frysinger,
> On Friday 20 July 2012 07:33:49 Marek Vasut wrote:
> > Dear Mike Frysinger,
> >
> > > On Wednesday 04 July 2012 10:39:20 Marek Vasut wrote:
> > > > > Putting there the __func__ name would improve structure and speed
> > > > > up finding right place.
> > > >
> > > > And if you want to use even __LINE__, look up __stringify patch in
> > > > the ML archives ;-)
> > >
> > > ugh, no, let's not use __LINE__ anywhere other than debug(). it has no
> > > business in code we ship as it is pointless bloated noise.
> >
> > Helps find out the problematic place in code ...
>
> except the code changes thus invalidating the line numbers, and how often
> are you putting the same string in multiple places that you can't easily
> coordinate where it came from ? if people are using the same exact string
> in multiple places, that sounds like a different problem.
You can always replace the function names with macros, which expand in place.
And then simply add __func__ __LINE__ __FILE__ etc.
> -mike
Best regards,
Marek Vasut
More information about the U-Boot
mailing list