[U-Boot] Invalid Netconsole source MAC address [was: Re: [STATUS] v2012.07-rc1 is out - release date July 23]

[Joe Hershberger]

Hi Michael,

On Mon, Jul 23, 2012 at 3:41 PM, Michael Walle <michael at walle.cc> wrote:
>
> Hi Joe,
>
> Am Montag 23 Juli 2012, 21:30:28 schrieb Joe Hershberger:
>> On Sat, Jul 21, 2012 at 1:04 PM, Michael Walle <michael at walle.cc> wrote:
>> > Mh i guess NetLoop isn't called and thus NetOurEther is never
>> > initialized. Similar issue like
>> > d7310c7e63ca9ffd42527dc9735cb505cbe908b7. Initializing NetOurEther in
>> > net_init() fixes the problem.
>>
>> I tested this on Panda board and wireshark reports the correct source
>> MAC address.
>>
>> Please provide details of which board and driver you are using.
>
> Board: LS-CHLv2/kirkwood arm; ethaddr set to some valid ethernet address ;)
>
> If NetLoop isn't called the internal ethernet address is not initialized.
> Hopefully the following sequence triggers the bug:
>  - boot the board, _dont_ do any network interaction
>  - setenv stdout nc
>  - type sth on the serial console
>
> --> now the packets are send with source MAC == 00:00:00:00:00:00.
>
> If you look at the code NetOurEther is only initialized in NetLoop and i guess
> NetLoop() isn't called for outgoing NetConsole packets.

Thanks for pointing this out.  I was able to reproduce it on panda and
have a fix for it.  I'll post it shortly.

-Joe