[U-Boot] [PATCH 0/2] New abstraction layer for handling MMC and FAT commands

[Wolfgang Denk]

Dear Lukasz Majewski,

In message <1343378116-5569-1-git-send-email-l.majewski at samsung.com> you wrote:
> New abstraction layer for performing MMC and FAT operations has been added.
> It is necessary for using MMC and FAT operations from other subsystems without
> the need to call "sprintf" and "run_command" afterwards.
> 
> MMC/FAT function call allows for better type checking during compilation time.
> For FAT, common code has been encapsulated to a separate function.
> 
> Lukasz Majewski (2):
>   mmc: New abstract function (do_mmcops_safe) for MMC subsystem
>   fat: New abstract function (do_fat_safe) for FAT subsystem

Sorry if I don't understand, but what exactly is special with MMC and
FAT here?

Why are the same changes as to the MMC code not also needed for
example for the IDE, SATA, SCSI or USB code?

Why are the same changes as for FAT not also needed for the other file
systems?


And what exactly are you changing anyway?  The commit messages in the
patches give neither sufficient information to understand why you make
a change at all, nor how the new code is supposed to be used, nor in
which way he is better ("more safe" ?) than the existing code?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You ain't experienced..." "Well, nor are you." "That's true. But the
point is ... the point is ... the point is we've been not experienced
for a lot longer than you. We've got  a  lot  of  experience  of  not
having any experience."           - Terry Pratchett, _Witches Abroad_