[U-Boot] [PATCH 1/2] COMMON: Add __stringify() function

Wolfgang Denk wd at denx.de
Sat Jul 28 21:36:54 CEST 2012


Dear Marek Vasut,

In message <1343483279-11572-1-git-send-email-marex at denx.de> you wrote:
> This function converts static number to string in preprocessor.
> This is useful as it allows higher usage of puts() in favour of printf()
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Mike Frysinger <vapier at gentoo.org>
> ---
>  include/common.h |    7 +++++++
>  1 file changed, 7 insertions(+)

We have similar things already, and we don't add dead code - you add a
macro without users here.

If you want to unify the use of such a macro, fine - but then please
replace all ocurrences of equivalent definitions all over the code.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Bus error -- driver executed.


More information about the U-Boot mailing list