[U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix

[Stefano Babic]

On 29/07/2012 03:33, Marek Vasut wrote:
> Dear Otavio Salvador,
> 

Hi Marek, Otavio,

>> As the register accessing mode is the same for all i.MXS SoCs we ought
>> to use 'mxs' prefix intead of 'mx28'.
>>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>>  arch/arm/cpu/arm926ejs/mxs/clock.c           |    4 +-
>>  arch/arm/cpu/arm926ejs/mxs/iomux.c           |    6 +-
>>  arch/arm/cpu/arm926ejs/mxs/mx28.c            |    6 +-
>>  arch/arm/include/asm/arch-mxs/regs-apbh.h    |  254
>> +++++++++++++------------- arch/arm/include/asm/arch-mxs/regs-bch.h     | 
>>  42 ++---
>>  arch/arm/include/asm/arch-mxs/regs-clkctrl.h |   58 +++---
>>  arch/arm/include/asm/arch-mxs/regs-common.h  |   34 ++--
>>  arch/arm/include/asm/arch-mxs/regs-digctl.h  |   50 ++---
>>  arch/arm/include/asm/arch-mxs/regs-gpmi.h    |   26 +--
>>  arch/arm/include/asm/arch-mxs/regs-i2c.h     |   28 +--
>>  arch/arm/include/asm/arch-mxs/regs-lcdif.h   |   64 +++----
>>  arch/arm/include/asm/arch-mxs/regs-lradc.h   |   48 ++---
>>  arch/arm/include/asm/arch-mxs/regs-ocotp.h   |   86 ++++-----
>>  arch/arm/include/asm/arch-mxs/regs-pinctrl.h |  168 ++++++++---------
>>  arch/arm/include/asm/arch-mxs/regs-power.h   |   28 +--
>>  arch/arm/include/asm/arch-mxs/regs-rtc.h     |   28 +--
>>  arch/arm/include/asm/arch-mxs/regs-ssp.h     |   40 ++--
>>  arch/arm/include/asm/arch-mxs/regs-timrot.h  |   38 ++--
>>  arch/arm/include/asm/arch-mxs/regs-usbphy.h  |   20 +-
>>  arch/arm/include/asm/arch-mxs/sys_proto.h    |    6 +-
>>  drivers/gpio/mxs_gpio.c                      |   16 +-
>>  drivers/usb/host/ehci-mxs.c                  |    8 +-
>>  22 files changed, 529 insertions(+), 529 deletions(-)
> [...]
> 
> Given that the PSU regs for example have completely different register map and 
> bit maps in the registers itself, I'd be careful with the renaming.
> 

Personally I prefer that the function names are the same and the
implementation itself of the function hides the SOC details. In this
way, we provide the same interface API to the user (=the board
maintainer) and to the drivers that are surely shared between the MX28
and MX23.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================