[U-Boot] [PATCH 1/2] cmd_nand: dump: Align data and OOB buffers

Simon Glass sjg at chromium.org
Tue Jul 31 09:00:14 CEST 2012


+Scott

On Tue, Jul 31, 2012 at 7:21 AM, Thierry Reding
<thierry.reding at avionic-design.de> wrote:
> In order for cache invalidation and flushing to work properly, the data
> and OOB buffers must be aligned to full cache lines.
>
> Signed-off-by: Thierry Reding <thierry.reding at avionic-design.de>

Acked-by: Simon Glass <sjg at chromium.org>

> ---
>  common/cmd_nand.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/cmd_nand.c b/common/cmd_nand.c
> index a91ccf4..4367f5a 100644
> --- a/common/cmd_nand.c
> +++ b/common/cmd_nand.c
> @@ -48,8 +48,8 @@ static int nand_dump(nand_info_t *nand, ulong off, int only_oob, int repeat)
>
>         last = off;
>
> -       datbuf = malloc(nand->writesize);
> -       oobbuf = malloc(nand->oobsize);
> +       datbuf = memalign(ARCH_DMA_MINALIGN, nand->writesize);
> +       oobbuf = memalign(ARCH_DMA_MINALIGN, nand->oobsize);
>         if (!datbuf || !oobbuf) {
>                 puts("No memory for page buffer\n");
>                 return 1;
> --
> 1.7.11.3
>


More information about the U-Boot mailing list