[U-Boot] [PATCH 1/2] COMMON: Add __stringify() function

Marek Vasut marex at denx.de
Tue Jul 31 15:55:55 CEST 2012


Dear Mike Frysinger,

> On Saturday 28 July 2012 15:57:33 Wolfgang Denk wrote:
> > Marek Vasut wrote:
> > > > >  include/common.h |    7 +++++++
> > > > >  1 file changed, 7 insertions(+)
> > > > 
> > > > We have similar things already, and we don't add dead code - you add
> > > > a macro without users here.
> > > 
> > > It's used in 2/2 ... what macro do you have in mind ?
> > 
> > Then add it with the patch that uses it.
> > 
> > As for existing use, see for example
> 
> there's also MK_STR() and XMK_STR().

Grunt ... how do you find those? Or is it that you just happened to run over 
them?

> would be good to import
> linux/stringify.h (rather than adding these macros to common.h) and
> converting all consumers over to that.

I wonder, what's the gain?

> -mike

Best regards,
Marek Vasut


More information about the U-Boot mailing list