[U-Boot] [PATCH] mx53loco: Define CONFIG_BOARD_LATE_INIT

Wolfgang Denk wd at denx.de
Tue Jul 31 21:56:46 CEST 2012


Dear Fabio Estevam,

In message <CAOMZO5CBpA4kVC+J6Yp8RwmL-EbLwK1PcYWC_RLX=SwWRnqsyg at mail.gmail.com> you wrote:
...
> 
> -#ifdef CONFIG_BOARD_LATE_INIT
>  int board_late_init(void)
>  {
> -	setenv("stdout", "serial");
> +	setenv("preboot", "setenv stdout serial\0");

NAK.  Please never, never ever mandatorily overwrite environment
variables!  The user who sets it to a different value and cannot find
out why his settings don;t work and always get overwritten would be
seriously frustrated.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If A equals success, then the formula is A = X + Y + Z. X is work.  Y
is play. Z is keep your mouth shut.                 - Albert Einstein


More information about the U-Boot mailing list