[U-Boot] [PATCH v7 4/4] Kirkwood: add lschlv2 and lsxhl board support

[Luka Perkov]

Hi Michael,

On Fri, Jun 01, 2012 at 12:58:41PM +0200, Michael Walle wrote:
> >> +#ifdef CONFIG_RESET_PHY_R
> >> +/* Configure and enable MV88E1118 PHY */
> >> +void reset_phy(void)
> >> +{
> >> +	u16 devadr;
> >> +	char *name = "egiga1";
> >> +
> >> +	if (miiphy_set_current_dev(name))
> >> +		return;
> >> +
> >> +	/* command to read PHY dev address */
> >> +	if (miiphy_read(name, 0xEE, 0xEE, (u16 *) &devadr)) {
> >> +		printf("Err..%s could not read PHY dev address\n", __func__);
> >> +		return;
> >> +	}
> >> +
> >> +	/* reset the phy */
> >> +	miiphy_reset(name, devadr);
> >> +}
> >> +#endif /* CONFIG_RESET_PHY_R */
> >
> > Can you please test without this part if your network will work?
> 
> Could you provide some more background why this should be superfluous?

Thing is that this part of the code is result of C/P from other boards. 
On some it's really neded like dlink dns320 or dns325 i dont remember 
which one. On some like ib62x0 it's not.

So whenever somebody sends patch for kirkwood board I want them to
double check if this is needed.

> Eg. what happens if an operating system changes some phy settings and
> reboots the system?

IMHO it should not have any effect.

Regards,
Luka