[U-Boot] [PATCH v8] kirkwood: add NAS62x0 board support

Marek Vasut marex at denx.de
Sat Jun 2 10:31:46 CEST 2012


Dear Luka Perkov,

> Hi Michael,
> 
> On Fri, Jun 01, 2012 at 11:03:16PM +0200, Michael Walle wrote:
> > > +/*
> > > + * Machine type
> > > + */
> > > +#define CONFIG_MACH_TYPE	MACH_TYPE_NAS6210
> > 
> > btw i guess this will break in about half a year. because:
> >  - uboot follows mach-types.h from the kernel
> >  - the kernel will only keep mach-types for boards which are supported by
> >  the
> >  
> >    kernel AND using the old-style machine init, that is no boards with no
> >    device tree support for booting.
> >  
> >  - no old style machine setups are accepted for kirkwood platforms
> >  anymore.
> > 
> > that means at some point of time in the future MACH_TYPE_NAS6210 wont be
> > defined anymore ;)
> > 
> > just wanted to letting you know.
> 
> I'm aware of that :)
> 
> This board is already accepted upstream, for more info look here:
> 
> commit f6a26ae7699416d86bea8cb68ce413571e9cab3c
> Merge: cdd3a35 48a5765
> Author: Linus Torvalds <torvalds at linux-foundation.org>
> Date:   Tue May 22 13:32:53 2012 -0700
> 
> Once 3.5 is out we'll patch uboot. Simon is the one that pushed support
> for this board upstream using device tree. Thanks Simon.

Why would you wait for 3.5 ? You can use -next .

> Luka

Best regards,
Marek Vasut


More information about the U-Boot mailing list