[U-Boot] [PATCH resend] Added watchdog support for davinchi_dm365evm

Tom Rini trini at ti.com
Mon Jun 4 23:26:41 CEST 2012


On 06/02/2012 01:38 PM, Stijn Souffriau wrote:
> ---
>  arch/arm/cpu/arm926ejs/davinci/dm365.c         |   61 ++++++++++++++++++++++++
>  arch/arm/include/asm/arch-davinci/timer_defs.h |    2 +
>  board/davinci/dm365evm/dm365evm.c              |   19 ++++++++
>  include/configs/davinci_dm365evm.h             |   11 +++++
>  4 files changed, 93 insertions(+)

First, the proper way to send revised patches is to put 'v2' or 'v3'
rather than resend in the subject and to include, after the full commit
message, "---" and then changes from v1 to v2, v2 to v3 and so forth.
Second, I just re-read this code and the in-tree
arch/arm/cpu/arm926ejs/davinci/timer.c code and think you really really
need to sort out what magic value(s) has changed slightly and re-use
that code.  The reset code is the same.  The programming sequence looks
to be the same.  I just didn't write out all of the non-0 values used to
see what's different.  I'm 99% certain this is small change from one
revision to another of the basic IP block and you need to see what bits
are being set (or not set!) in both cases and see what the differences
between them are all about.

-- 
Tom


More information about the U-Boot mailing list