[U-Boot] [PATCH] da850/omap-l138: Enable auto negotiation in RMII mode

[Lad, Prabhakar]

Hi Tom,
On Tue, Jun 05, 2012 at 03:59:08, Rini, Tom wrote:
> On Fri, Jun 01, 2012 at 07:04:37PM +0530, Prabhakar Lad wrote:
> > From: Rajashekhara, Sudhakar <sudhakar.raj at ti.com>
> > 
> > On DA850/OMAP-L138 it was observed that in RMII mode, auto negotiation 
> > was not performed. This patch enables auto negotiation in RMII mode. 
> > Without this patch, EMAC initialization takes more time and sometimes 
> > tftp fails in RMII mode.
> > 
> > Signed-off-by: Rajashekhara, Sudhakar <sudhakar.raj at ti.com>
> > Signed-off-by: Lad, Prabhakar <prabhakar.lad at ti.com>
> > Signed-off-by: Hadli, Manjunath <manjunath.hadli at ti.com>
> > ---
> >  drivers/net/davinci_emac.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c 
> > index fbd0f1b..9bbd625 100644
> > --- a/drivers/net/davinci_emac.c
> > +++ b/drivers/net/davinci_emac.c
> > @@ -895,5 +895,10 @@ int davinci_emac_initialize(void)
> >  		miiphy_register(phy[i].name, davinci_mii_phy_read,
> >  						davinci_mii_phy_write);
> >  	}
> > +
> > +#if defined(CONFIG_DRIVER_TI_EMAC_USE_RMII) && \
> > +		defined(CONFIG_MACH_DAVINCI_DA850_EVM)
> > +	gen_auto_negotiate(active_phy_addr);
> > +#endif
> 
> Why not just check on CONFIG_DRIVER_TI_EMAC_USE_RMII ?  Would it be harmful to try and re-auto negotiate on some RMII hardware that already did it?
Some of the phy's might not support auto negotiation, Not sure what will be
the behavior on these phy's on enabling auto negotiation. So as to avoid this case this check is added.

Thx,
--Prabhakar Lad
> 
> --
> Tom
>