[U-Boot] [PATCH v2 06/10] ARM: add tegra20 support to arm720t

[Stephen Warren]

On 06/06/2012 12:25 PM, Allen Martin wrote:
> On Wed, Jun 06, 2012 at 09:39:57AM -0700, Stephen Warren wrote:
>> On 06/05/2012 03:20 PM, Allen Martin wrote:
>>> Add support for tegra20 arm7 boot processor.  This processor is used
>>> to power on the Cortex A9 and transfer control to it.
>>
>>> diff --git a/arch/arm/cpu/arm720t/cpu.c b/arch/arm/cpu/arm720t/cpu.c
>>
>>>  #elif defined(CONFIG_INTEGRATOR) && defined(CONFIG_ARCH_INTEGRATOR)
>>>  	/* No cleanup before linux for IntegratorAP/CM720T as yet */
>>> +#elif defined (CONFIG_MACH_TEGRA_GENERIC)
>>> +	/* No cleanup before linux for tegra as yet */
>>>  #else
>>>  #error No cleanup_before_linux() defined for this CPU type
>>>  #endif
>>
>> Wouldn't CONFIG_TEGRA2 be a better define to use? Same comment throughout.
> 
> The SPL *should* work on tegra30 with only minor changes, so just
> trying to look forward.

Oh, I see. MACH_TEGRA_GENERIC means "some Tegra SoC", and CONFIG_TEGRA*
indicate which one. Coming from my kernel background, MACH_* is a define
for a particular board, and we do have a GENERIC Tegra board, so I got
the wrong end of the stick.

I wonder if it's worth renaming CONFIG_MACH_TEGRA_GENERIC to
CONFIG_TEGRA. There don't appear to be any users of it currently.