[U-Boot] [PATCH][v2] powerpc/CoreNet: add tool to support pbl image build.

[Wolfgang Denk]

Dear Xie Shaohui-B21989,

In message <ED492CCEAF882048BC2237DE806547C907968C56 at 039-SN2MPN1-012.039d.mgd.msft.net> you wrote:
>
> >I want to get rid if config.mk files to the extend possible - and here I
> >see no need for a new one.
> [Xie Shaohui] Actually, I was hesitate to use the config.mk file, I found other person define the "CONFIG_XXX_CONFIG" in header files, but when I tried the same way, the checkpatch.pl complained that $(SRCTREE)/$(CONFIG_BOARDDIR)/pblimage.cfg should be wrapped by Parentheses, but the Parentheses will make the cfg file cannot be found because the Parentheses was included in path of the cfg file. Should I ignore the complain of the checkpatch.pl?

Yes.

And please - restrict your line length so some 70 characters or so.
Thanks.

> >You don;t expect us to edit this fiule just when building for another
> >target?  Please find a solution that works without editing source files.
> [Xie Shaohui] Maybe I should have another file for RCW... 
> Just building does not need to edit this file; this is only needed for real board.

This is what I mean - it is mandatory that you can build U-Boot for
any real board without modifying any source files, and with only
including files that are checked in into the git repository.

> >Also, such a command should never be necessary - the "make" system should
> >catch any such situations automatically.  If it doesn't, then please fix
> >this.
> [Xie Shaohui] It *is* not necessary, for ex I've built a boot Image, but I want to try another configuration file, I only need to run this command with new configuration file, I do not need to rebuild everything.

Yes, but this should be covered by the Makefile - the user should
never need to know any such internal details.

> [Xie Shaohui] I just followed what people done. A bad day for me...

Not really.  Don't be frustrated.  These were actually very few
remarks on pretty long and complex code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In my experience the best way to get something done  is to give it to
someone who is busy.               - Terry Pratchett, _Going_Postal_