[U-Boot] [PATCH] net/designware: Add-on: Consecutive writes must have delay
Wolfgang Denk
wd at denx.de
Fri Jun 8 00:32:03 CEST 2012
Dear Dinh,
In message <1339104480-6191-1-git-send-email-dinguyen at altera.com> you wrote:
> This commit is an add-on to f6c4191f. There are a few other registers where
> consecutive writes must have a delay.
Sorry, but this commit message is misleading - I was expecting to see
something like udelay() in the code, but there wasn't any...
> Signed-off-by: Dinh Nguyen <dinguyen at altera.com>
> ---
> drivers/net/designware.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/designware.c b/drivers/net/designware.c
> index e8e669b..34952c0 100644
> --- a/drivers/net/designware.c
> +++ b/drivers/net/designware.c
> @@ -163,8 +163,8 @@ static int dw_eth_init(struct eth_device *dev, bd_t *bis)
> writel(FIXEDBURST | PRIORXTX_41 | BURST_16,
> &dma_p->busmode);
>
> - writel(FLUSHTXFIFO | readl(&dma_p->opmode), &dma_p->opmode);
> - writel(STOREFORWARD | TXSECONDFRAME, &dma_p->opmode);
> + writel(readl(&dma_p->opmode) | FLUSHTXFIFO | STOREFORWARD | \
> + TXSECONDFRAME, &dma_p->opmode);
There is no need for the continuation line here; please drop the
backslash.
Hm... Should we not rather use something like setbits_le32() here?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You said you didn't want to use CGI.pm, but methinks you are
needlessly reinventing the wheel, one spoke at a time. Either you are
masochistic, or you just haven't seen enough of what CGI.pm can do
for you. -- Randal L. Schwartz in <8cyb81rg81.fsf at gadget.cscaper.com>
More information about the U-Boot
mailing list