[U-Boot] [PATCH 1/3] imx25: Move MXC_GPIO_PORT_TO_NUM to imx-regs.h

[Troy Kisky]

On 6/11/2012 8:00 AM, Vikram Narayanan wrote:
> On 6/10/2012 8:03 PM, Fabio Estevam wrote:
>> Hi Vikram,
>>
>> On Sun, Jun 10, 2012 at 10:02 AM, Vikram 
>> Narayanan<vikram186 at gmail.com>  wrote:
>>
>>> +
>>> +/* Converts a GPIO port number and the internal bit position
>>> + * to the GPIO number
>>> + */
>>> +#define MXC_GPIO_PORT_TO_NUM(port, bit) (((port - 1)<<  5) + (bit&  
>>> 0x1f))
>>
>> Just a minor comment:
>>
>> MXC_GPIO_PORT_TO_NUM looks like a very looong string.
>>
>> Couldn't we use the same macro as in the Linux kernel (IMX_GPIO_NR) 
>> instead?
>>
>> It is more concise and it would nice to have the same macro name for
>> kernel and U-boot.
>>
>> What do you think?
>
> Yes. That should be a better option. I'll go with it.

We have this line already

arch/arm/include/asm/arch-mx6/imx-regs.h:#define GPIO_NUMBER(port, 
index)               ((((port)-1)*32)+((index)&31))

>
> ~Vikram
>
>> Thanks,
>>
>> Fabio Estevam
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> .
>