[U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type

Marek Vasut marex at denx.de
Sun Jun 17 15:30:17 CEST 2012


Dear Fabio Estevam,

> On Sun, Jun 17, 2012 at 10:09 AM, Otavio Salvador
> 
> <otavio at ossystems.com.br> wrote:
> > On Sun, Jun 17, 2012 at 10:05 AM, Fabio Estevam <festevam at gmail.com> wrote:
> >>>        default:
> >>> -               return "unknown";
> >>> +               return "<unidentified>";
> >> 
> >> I really don't see any improvement here.
> > 
> > It is just to avoid a i.MXunkown return; besides this is how I am
> > doing in the mx23 code too.
> 
> This is OK. If you read "i.MXunkown" things are too broken already
> because the chip version could not be read.
> 
> Reading "i.MX<unidentified>" will make things no better.

This was from my head actually ... and I think this is better. The text is at 
least not mangled so badly. So let's keep it.

Best regards,
Marek Vasut


More information about the U-Boot mailing list