[U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()

Marek Vasut marex at denx.de
Sun Jun 17 20:41:49 CEST 2012


Dear Otavio Salvador,

> On Sun, Jun 17, 2012 at 2:56 PM, Stefano Babic <sbabic at denx.de> wrote:
> >> Correct, but isn't the return value mangled somehow (like having major
> >> rev. << 16 and minor rev. << 0 )? Or that's only IMX?
> > 
> > Checking in current implementations for get_cpu_rev() (i.MX / OMAP24 /
> > OMAP3 / AM33, and even board/apollon/sys_info.c: I do not know why the
> > cpu detection is inseide this file), none of them requires strictly 32
> > bit. However, we should be coherent in all code - for this reason I
> > dislike if one of the i.MX is implemented differently as for other SOCs.
> 
> So, we change this one to follow the others or fix the others?

Fix the others ;-)

Best regards,
Marek Vasut


More information about the U-Boot mailing list