[U-Boot] [PATCH 2/4] mx53loco: add a comment about local copy of print_cpuinfo method

Wolfgang Denk wd at denx.de
Sun Jun 24 09:53:20 CEST 2012


Dear Otavio Salvador,

In message <1340482108-18468-2-git-send-email-otavio at ossystems.com.br> you wrote:
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  board/freescale/mx53loco/mx53loco.c |    2 ++
>  1 file changed, 2 insertions(+)

Argh!!! Plese read
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

Please mark updated versions of a patch in the Subject:, and include a
change log.

> +/* Needs to be available on the board file to be called in board_init,
> + * instead of normal order  */

This cmment makes no sense to me.

Also, this is incorrect multi-line comment style.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
First study the enemy.  Seek weakness.
	-- Romulan Commander, "Balance of Terror", stardate 1709.2


More information about the U-Boot mailing list