[U-Boot] [PATCH] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0

Tetsuyuki Kobayashi koba at kmckk.co.jp
Mon Jun 25 14:42:29 CEST 2012


save_boot_params_default() in cpu.c accesses uninitialized stack area
when it compiled with -O0 (not optimized).

Signed-off-by: Tetsuyuki Kobayashi <koba at kmckk.co.jp>
---
 arch/arm/cpu/armv7/cpu.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/cpu/armv7/cpu.c b/arch/arm/cpu/armv7/cpu.c
index c6fa8ef..6104cb2 100644
--- a/arch/arm/cpu/armv7/cpu.c
+++ b/arch/arm/cpu/armv7/cpu.c
@@ -37,8 +37,11 @@
 #include <asm/cache.h>
 #include <asm/armv7.h>
 
+__attribute__((naked)) /* don't save anything to stack even if compiled with -O0 */
 void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3)
 {
+	/* stack is not yet initialized */
+	asm("bx lr");
 }
 
 void save_boot_params(u32 r0, u32 r1, u32 r2, u32 r3)
-- 
1.7.9.5



More information about the U-Boot mailing list