[U-Boot] [PATCH v5 00/13] split tegra20 arm7 code into separate SPL

Tom Warren TWarren at nvidia.com
Tue Jun 26 01:40:46 CEST 2012


Allen,

> -----Original Message-----
> From: Allen Martin [mailto:amartin at nvidia.com]
> Sent: Monday, June 25, 2012 4:21 PM
> To: Stephen Warren
> Cc: Tom Warren; sjg at chromium.org; thierry.reding at avionic-design.de; u-
> boot at lists.denx.de
> Subject: Re: [PATCH v5 00/13] split tegra20 arm7 code into separate SPL
> 
> On Mon, Jun 25, 2012 at 04:04:28PM -0700, Stephen Warren wrote:
> > On 06/25/2012 04:55 PM, Allen Martin wrote:
> > > This patch series fixes a long standing problem with the tegra20
> > > u-boot build.  Tegra20 contains an ARM7TDMI boot processor and a
> > > Cortex A9 main processor.  Prior to this patch series this was
> > > accomplished by #ifdefing out any armv7 code from the early boot
> > > sequence and creating a single binary that runs on both both the
> > > ARM7TDMI and A9.  This was very fragile as changes to compiler
> > > options or any additions or rearranging of the early boot code could
> > > add additional armv7 specific code causing it to fail on the ARM7TDMI.
> > >
> > > This patch series pulls all the armv4t code out into a separate SPL
> > > that does nothing more than initialize the A9 and transfer control
> > > to it.  The resultint SPL and armv7 u-boot are concatenated together
> > > into a single image.
> > >
> > > This patch series is also available from:
> > > git://github.com/arm000/u-boot.git
> > > branch: tegra-spl-v5
> > >
> > > Changes:
> > > v5:
> > >  - added missing mkdir rules in all tegra20 board Makefiles that
> > > include common code and changed them to be unconditional
> > >  - make new u-boot-dtb-t2.bin rule default for tegra20 and copy
> > > resulting binary over u-boot.bin
> >
> > Doesn't that then destroy the original u-boot.bin so it can't be
> inspected?
> 
> Good point, perhaps I should back it up first?  I was trying to respond to
> Tom's objection that people expect the final binary to be u-boot.bin, and
> it's confusing if it's not.  I don't really want to mess with the standard
> u-boot.bin rule, so how about backing it up to "u-boot-tegra.bin" and making
> "u-boot.bin" be the final image ?

My objection was that we were getting too many/multiple 'final' binary images, and people wouldn't know which one to flash. If it's still a DT build, then the final output binary should probably be u-boot-dtb.bin, since most people should be retrained to look for that now. U-boot.bin should still give an error message if you flash it by mistake (behave the same as builds prior to SPL). If you want to provide a backup of an intermediate image, call it something with a partial or intermediate name so folks won't try to flash it, or change the extension to something other than .bin.

Thanks,

Tom
> 
> -Allen
--
nvpublic


More information about the U-Boot mailing list