[U-Boot] [PATCH v2 2/3] AM335x : Configs to add USB host support.

[Sohanpal, Harman]

> -----Original Message-----
> From: Tom Rini [mailto:tom.rini at gmail.com] On Behalf Of Rini, Tom
> Sent: Friday, June 22, 2012 9:25 PM
> To: Sohanpal, Harman
> Cc: u-boot at lists.denx.de; sr at denx.de
> Subject: Re: [U-Boot] [PATCH v2 2/3] AM335x : Configs to add USB host
> support.
> 
> On Fri, Jun 22, 2012 at 01:36:34PM +0530, Harman Sohanpal wrote:
> 
> > This patch adds required configs in config file for
> > am335x_evm to add support for usb host mode.
> > To enable USB device mode, add CONFIG_MUSB_UDC in
> > place of CONFIG_MUSB_HCD
> 
> But you haven't tested / added support for device mode yet, so please
> remove those references.
> 
> [snip]
> > +/*
> > + * USB configuration
> > + * Enable CONFIG_MUSB_HCD for Host functionalities MSC, keyboard
> > + * Enable CONFIG_MUSB_UDC for Device functionalities.
> > + */
> > +#define CONFIG_USB_AM335X
> > +#define CONFIG_MUSB_HCD
> > +
> > +#ifdef CONFIG_USB_AM335X
> 
> We don't need an extra test of CONFIG_USB_AM335X around this, just
> CONFIG_MUSB_HCD and later MUSB_UCD.
> 
> [snip]
> > +#ifdef CONFIG_USB_KEYBOARD
> > +#define CONFIG_SYS_USB_EVENT_POLL
> > +#define CONFIG_PREBOOT "usb start"
> > +#endif /* CONFIG_USB_KEYBOARD */
> 
> You didn't add nor test keyboard so please remove these bits until
> U-Boot support is at the point where you could use one of these boards
> over a display rather than USB console :)  Thanks.
> 
Tom,
Thanks for the review.
I have tested the device mode using usbtty on 
beaglebone.
Although I have not tested keyboard so will remove those configs 
and would add it when tested.
Also would remove the extra test of CONFIG_USB_AM335X in 
next set of patches.
Thanks,
Harman