[U-Boot] [RFC][PATCH] net: nfs: extend NFS_TIMEOUT

[Joe Hershberger]

Hi Tetsuyuki,

On Tue, Jun 26, 2012 at 3:52 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Tetsuyuki Kobayashi,
>
> In message <4FE9711A.2090602 at kmckk.co.jp> you wrote:
>>
>> >> Are you sure the problems are not in the board specific code?
>> > OK. I will try the same thing on an in-tree board (maybe, panda board) to check if this is board specific or not.
>>
>> I did on a panda board. It has the same problem and this patch solves it. So this is not board specific problem. Please consider to change global setting of NFS_TIMEOUT in nfs.c.
>
> net/nfs.c is not the right place to make board specific adjustments.
>
> I am still not convinced this is an issue with the global code.  It
> could be your NFS server as well.

I'm not convinced either.  It clearly depends on the speed of your
server, the speed of the connection, the size of the file you are
transferring, etc.

> If there are really boards which need longer timeouts, these should be
> set in the board config files.

In fact I would rather the constant were not defined there at all... but it is.

At a minimum it should look like this:


 #define HASHES_PER_LINE 65     /* Number of "loading" hashes per line  */
 #define NFS_RETRY_COUNT 30
+#ifdef CONFIG_NFS_TIMEOUT
+#define NFS_TIMEOUT CONFIG_NFS_TIMEOUT
+#else
 #define NFS_TIMEOUT 2000UL
+#endif

 static int fs_mounted;
 static unsigned long rpc_id;


...with CONFIG_NFS_TIMEOUT defined for your board.

-Joe