[U-Boot] [PATCH 1/2] microblaze: avoid compile error on systems without cfi flash

Stephan Linz linz at li-pro.net
Tue Jun 26 18:56:47 CEST 2012


Am Dienstag, den 26.06.2012, 10:56 +0200 schrieb Michal Simek: 
> 2012/6/25 Stephan Linz <linz at li-pro.net>:
> > Am Montag, den 25.06.2012, 06:55 +0200 schrieb Michal Simek:
> >> On 06/21/2012 09:42 PM, Stephan Linz wrote:
> >> > Use XILINX_FLASH_START to set/unset FLASH and RAMENV.
> >> >
> >> > Error was:
> >> > board.c: In function 'board_init':
> >> > board.c:134: error: 'XILINX_FLASH_START' undeclared (first use in this function)
> >> > board.c:134: error: (Each undeclared identifier is reported only once
> >> > board.c:134: error: for each function it appears in.)
> >> >
> >> > Signed-off-by: Stephan Linz<linz at li-pro.net>
> >> > ---
> >> >   include/configs/microblaze-generic.h |   14 +++++++++-----
> >> >   1 files changed, 9 insertions(+), 5 deletions(-)
> >> >
> >> > --snip--
> >>
> >> What's wrong with hardware flash protection?
> >
> > Nothing, but it will defined twice. One time in line 182 and one time in
> > that line 204. I think the last one is wrong, because that define is
> > outside the Flash configuration context, or not?
> >
> > Sorry, I should split the patch. Should I do this?
> 
> Two ways.
> 1. write it to description
> 2. create separate patch
> 
> Option 2 is IMHO better.

Yes I do so. I'll split the patch and resubmit together with the UBI
support patch.

br,
Stephan



More information about the U-Boot mailing list