[U-Boot] [PATCH v3 1/3] AM335x : Add USB support for AM335x in u-boot

[Ilya Yanok]

Hi,

Harman Sohanpal <harman_sohanpal <at> ti.com> writes:
> +/* Control Module Registers */
> +#define CM_REGISTERS			CTRL_BASE
> +#define USB_CTRL0_REG_OFFSET	(0x628)
> +#define USB_CTRL1_REG_OFFSET	(0x680)

USB_CTRL1 seems to be unused. Furthermore, both values seems to be incorrect:
according to the RM USB_CTRL0 offset should be 0x628 and USB_CTRL1 should be
0x628. I understand that's cause you use USB1 by default but that's kind of
misguiding. Could you please use the approach Tom suggested for base address
here too? Define USB_CRTL* to correct values but use USB_CONTROL_REG_OFFSET
(defined conditionally) in code?

Regards, Ilya.