[U-Boot] [PATCH 2/3] ventana: define CONFIG_MACH_VENTANA

Stephen Warren swarren at nvidia.com
Thu Mar 1 22:30:12 CET 2012


On 03/01/2012 02:13 PM, Troy Kisky wrote:
> ventana uses board/nvidia/seaboard/seaboard.c
> which uses machine_is_ventana.

> diff --git a/include/configs/ventana.h b/include/configs/ventana.h

> +#define CONFIG_MACH_VENTANA

It'd be nice not to have to do this; that header already does:

#define CONFIG_MACH_TYPE                MACH_TYPE_VENTANA

Can't the code key off that? Otherwise, any use of machine_is_xxx() will
be very error-prone, since CONFIG_MACH_XXX has to be manually defined,
and people will forget.

-- 
nvpublic


More information about the U-Boot mailing list