[U-Boot] [PATCH] [PATCH] net/eth.c: Avoid Warning when ethxaddr is not set
Wolfgang Denk
wd at denx.de
Sat Mar 3 15:44:48 CET 2012
Dear Gwenhael Goavec-Merou,
In message <1330780211-90427-1-git-send-email-gwenhael.goavec-merou at armadeus.com> you wrote:
> The return value for eth_getenv_enetaddr_by_index produces
> a Warning when ethXaddr is not set (env_enetaddr is equal
> to 00:00:00:00:00:00).
>
> The validity of the mac address is tested later in this
> function to avoid to write an erroneous address.
>
> The test of the function's return is consequently useless
> and adds a warning.
Which use case do you have in mind? Why do you think this warning is
bad? I tend to consider it helpful instead.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"No matter where you go, there you are..." - Buckaroo Banzai
More information about the U-Boot
mailing list