[U-Boot] [PATCH] integrator: rewrite the AP PCI driver

Wolfgang Denk wd at denx.de
Sat Mar 3 16:28:02 CET 2012

Dear "Linus Walleij",

In message <1327967374-1727-1-git-send-email-linus.walleij at linaro.org> you wrote:
> The PCI support for the Integrator AP has apparently never
> been finished and I strongly suspect that it has never worked,
> so let's fix it. This is a list of the more or less
> un-splittable changes done in this driver rewrite:
> - Replace the register definitions stashed into the config
>   file (!) with a copy if the register file from the Linux
>   kernels arch/arm/include/asm/hardware/pci_v3.h
> - Delete the unreadable gigantic macros that perform the
>   config accesses and replace them with copyedited code from
>   Linux arch/arm/mach-integrator/pci_v3.c
> - Rewrite the rest of the setup code to use the
>   v3_[read|write][lwb]() accessors.
> - Enable PCI by default in the AP board configuration.
> - Fix checkpatch warnings and make code more conformant.
> Tested-by: Will Deacon <will.deacon at arm.com>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>

This commit causes build warnings on a number of boards, for example:

Configuring for integratorap_cm926ejs - Board: integratorap, Options: CM926EJ_S
pci.c: In function 'pci_init_board':
pci.c:474:2: warning: implicit declaration of function 'pciauto_config_init' [-Wimplicit-function-declaration]
pci.c:286:18: warning: variable 'j' set but not used [-Wunused-but-set-variable]

Please fix!

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women, and engi-
neers. While the first two are more pleasant, the third is by far the
more certain."                           - Baron Rothschild, ca. 1800

More information about the U-Boot mailing list