[U-Boot] [PATCH 2/4] net: fec_mxc: allow use with cache enabled

Eric Nelson eric.nelson at boundarydevices.com
Mon Mar 5 14:43:54 CET 2012


On 03/04/2012 06:49 PM, Marek Vasut wrote:
>> On 03/02/2012 04:39 PM, Marek Vasut wrote:
>>>> +			 * Invalidate data cache over the buffer
>>>> +			 */
>>>> +			addr = (uint32_t)frame;
>>>> +			size = roundup(frame_length, CONFIG_FEC_DATA_ALIGNMENT);
>>>> +			invalidate_dcache_range(addr, addr + size);
>>>
>>> DTTO here, frame length might not be aligned properly, or will it be?
>>> Network stack must be properly analyzed here.
>>
>> The hardware won't return an unaligned value here, so this should be good.
>
> Are you sure? You can't receive frame aligned to 8 bytes boundary?

Unless I'm missing something, received packet start addresses are defined
by the driver in fec_rbd_init(), the code just modified to use memalign,
so we're good here.


More information about the U-Boot mailing list