[U-Boot] [PATCH] MAKEALL: Add -m/-M option to determine maintainers

[Mike Frysinger]

On Monday 05 March 2012 16:11:08 Marek Vasut wrote:
> +get_target_location() {
> +	target=$1
> +
> +	BOARD_NAME=""
> +	CONFIG_NAME=""
> +	board=""
> +	vendor=""

please use "local" when declaring variables that are function local

> +	line=`egrep -i "^[[:space:]]*${target}[[:space:]]" boards.cfg`

obviously i prefer $(...) rather than `...`

> +	if [ -z "${line}" ] ; then echo "" ; return ; fi

please unroll

> +	[ "${BOARD_NAME}" ] || BOARD_NAME="${1%_config}"

	: ${BOARD_NAME:=${1%_config}}

> +	[ $# -gt 6 ] && [ "$7" != "-" ] && {

please use:
	if ... ; then

> +	if ! grep -i ${name} MAINTAINERS >/dev/null 2>&1 ; then

use -qs and then you can drop the redirects

> +		return ;

drop the semi-colon
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120305/31a62205/attachment.pgp>